From daec01eba0c187a09cfb92de4d7473ec31d969d5 Mon Sep 17 00:00:00 2001 From: leigh-mil Date: Wed, 12 Jun 2019 15:58:35 -0400 Subject: [PATCH 1/9] Format LOA fields --- styles/sections/_task_order.scss | 19 ++++++++++++++++++ templates/task_orders/edit.html | 34 +++++++++++++++++++++++--------- 2 files changed, 44 insertions(+), 9 deletions(-) diff --git a/styles/sections/_task_order.scss b/styles/sections/_task_order.scss index e9fcc9b8..9b84e463 100644 --- a/styles/sections/_task_order.scss +++ b/styles/sections/_task_order.scss @@ -77,6 +77,25 @@ .usa-alert { margin: 1.5em 0; } + + .task-order__loa-fieldset { + .usa-input { + margin: 0; + } + + input { + margin: $gap 0; + max-width: unset; + } + + input:first-child { + margin-top: 0; + } + + input:last-child { + margin-bottom: 0; + } + } } .row.row__form-fields { diff --git a/templates/task_orders/edit.html b/templates/task_orders/edit.html index 6e0c9007..3bcf58f3 100644 --- a/templates/task_orders/edit.html +++ b/templates/task_orders/edit.html @@ -13,8 +13,7 @@ {% macro LOAInput() %}
-
- +
-
Line of accounting (43 characters)
- {% for loa in fields.loas %} - {{ TextInput(loa, showLabel=False) }} - {% endfor %} +
+
+ +
+ Line of accounting (43 characters) +
+
+ {% for loa in fields.loas %} + {{ TextInput(loa, showLabel=False) }} + {% endfor %} + + {{ LOAInput() }} +
+
- {{ LOAInput() }} {{ DatePicker(fields.start_date) }} {{ DatePicker(fields.end_date) }} {{ TextInput(fields.obligated_amount, validation='dollars') }} @@ -190,8 +198,16 @@
-
Line of accounting (43 characters)
- {{ LOAInput() }} +
+
+ +
+ Line of accounting (43 characters) +
+
+ {{ LOAInput() }} +
+
From cd0433d85b8e4e1f248ad053f25bd91dccf0dbcc Mon Sep 17 00:00:00 2001 From: leigh-mil Date: Wed, 12 Jun 2019 16:12:59 -0400 Subject: [PATCH 2/9] Reduce space around input fields and add file size info to file upload --- atst/forms/task_order.py | 1 + styles/sections/_task_order.scss | 8 ++++++++ templates/task_orders/edit.html | 2 +- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/atst/forms/task_order.py b/atst/forms/task_order.py index 2585a673..7d02d3a6 100644 --- a/atst/forms/task_order.py +++ b/atst/forms/task_order.py @@ -41,6 +41,7 @@ class TaskOrderForm(BaseForm): ) pdf = FileField( None, + description="Your file may not exceed 50MB", validators=[ FileAllowed(["pdf"], translate("forms.task_order.file_format_not_allowed")), FileLength(message=translate("forms.validators.file_length")), diff --git a/styles/sections/_task_order.scss b/styles/sections/_task_order.scss index 9b84e463..2f000ad0 100644 --- a/styles/sections/_task_order.scss +++ b/styles/sections/_task_order.scss @@ -78,6 +78,10 @@ margin: 1.5em 0; } + .usa-input { + margin: $gap 0; + } + .task-order__loa-fieldset { .usa-input { margin: 0; @@ -96,6 +100,10 @@ margin-bottom: 0; } } + + .task-order__pdf-help-text { + margin-bottom: 4 * $gap; + } } .row.row__form-fields { diff --git a/templates/task_orders/edit.html b/templates/task_orders/edit.html index 3bcf58f3..a2961843 100644 --- a/templates/task_orders/edit.html +++ b/templates/task_orders/edit.html @@ -366,7 +366,7 @@
Upload your supporting documentation
-
+
Upload a single PDF containing all relevant information. {{ Icon('help')}}
{{ UploadInput(form.pdf) }} From 88fe358ced750862b3701f2aae7bbc123ac3fd26 Mon Sep 17 00:00:00 2001 From: leigh-mil Date: Wed, 12 Jun 2019 16:21:29 -0400 Subject: [PATCH 3/9] Fix spacing --- styles/sections/_task_order.scss | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/styles/sections/_task_order.scss b/styles/sections/_task_order.scss index 2f000ad0..a2b72229 100644 --- a/styles/sections/_task_order.scss +++ b/styles/sections/_task_order.scss @@ -58,6 +58,10 @@ } &.task_order__form { + hr { + margin-top: 2rem; + } + .totals-box { margin-top: 0; } @@ -66,7 +70,7 @@ left: 100%; } - .usa-input--validation--dollars input { + input { max-width: unset; } @@ -89,7 +93,6 @@ input { margin: $gap 0; - max-width: unset; } input:first-child { @@ -101,6 +104,10 @@ } } + button.icon-link { + padding: $gap * 3 0 0; + } + .task-order__pdf-help-text { margin-bottom: 4 * $gap; } From d8f7f7e912a43d53d1ca4f49ce9a657f25902e37 Mon Sep 17 00:00:00 2001 From: leigh-mil Date: Wed, 12 Jun 2019 16:44:59 -0400 Subject: [PATCH 4/9] Fix spacing on CLIN type and number, use .form-row in macro --- styles/sections/_task_order.scss | 42 +++++++++++++++++++++++--------- templates/task_orders/edit.html | 14 +++++------ 2 files changed, 37 insertions(+), 19 deletions(-) diff --git a/styles/sections/_task_order.scss b/styles/sections/_task_order.scss index a2b72229..c72f990b 100644 --- a/styles/sections/_task_order.scss +++ b/styles/sections/_task_order.scss @@ -83,7 +83,29 @@ } .usa-input { - margin: $gap 0; + margin-top: $gap; + margin-bottom: $gap; + } + + .form-row { + margin-bottom: 0; + + .usa-input { + margin-left: $gap; + margin-right: $gap; + } + + .form-col:first-child { + .usa-input { + margin-left: 0; + } + } + + .form-col:last-child { + .usa-input { + margin-right: 0; + } + } } .task-order__loa-fieldset { @@ -105,7 +127,13 @@ } button.icon-link { - padding: $gap * 3 0 0; + margin-top: 0; + margin-left: 0; + padding-left: 0; + + &.icon-link__add-another-clin { + margin-top: $gap * 3; + } } .task-order__pdf-help-text { @@ -113,16 +141,6 @@ } } - .row.row__form-fields { - .col { - margin-left: $gap; - } - - .col:first-child { - margin-left: 0; - } - } - .panel { @include shadow-panel; } diff --git a/templates/task_orders/edit.html b/templates/task_orders/edit.html index a2961843..edaae783 100644 --- a/templates/task_orders/edit.html +++ b/templates/task_orders/edit.html @@ -60,11 +60,11 @@ v-bind:initial-loa-count="{{ fields.loas.data | length }}" inline-template>
-
-
+
+
{{ OptionsInput(fields.jedi_clin_type) }}
-
+
{{ TextInput(fields.number) }}
@@ -144,8 +144,8 @@
-
-
+
+
@@ -162,7 +162,7 @@
-
+
- -
- -
- Start of period of performance (PoP) -
-
- -
- - -
- - -
- -
- - -
- -
- - - -
- -
- {{ Icon("ok", classes="icon--green") }} -
-
-
-
- - -
- -
- End of period of performance (PoP) -
-
- -
- - -
- - -
- -
- - -
- -
- - - -
- -
- {{ Icon("ok", classes="icon--green") }} -
-
-
-
- - -
- - - - - - - - - -
-
-
- -
- - - -
-
Upload your supporting documentation
-
- Upload a single PDF containing all relevant information. {{ Icon('help')}} -
- {{ UploadInput(form.pdf) }} +
+
Upload your supporting documentation
+
+ Upload a single PDF containing all relevant information. {{ Icon('help')}} +
+ {{ UploadInput(form.pdf, watch=True) }} +
+ {{ TotalsBox(task_order=task_order) }}
- {{ TotalsBox(task_order=task_order) }}
From 66b0cb7e7585c9f5c2ffcb163da7601df287e1f3 Mon Sep 17 00:00:00 2001 From: leigh-mil Date: Fri, 14 Jun 2019 10:56:57 -0400 Subject: [PATCH 8/9] Fix spacing and update icon --- static/icons/question.svg | 1 + styles/sections/_task_order.scss | 9 +++++++-- templates/task_orders/edit.html | 2 +- 3 files changed, 9 insertions(+), 3 deletions(-) create mode 100644 static/icons/question.svg diff --git a/static/icons/question.svg b/static/icons/question.svg new file mode 100644 index 00000000..33f994c4 --- /dev/null +++ b/static/icons/question.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/styles/sections/_task_order.scss b/styles/sections/_task_order.scss index 1a52811a..e124cdae 100644 --- a/styles/sections/_task_order.scss +++ b/styles/sections/_task_order.scss @@ -59,7 +59,7 @@ &.task_order__form { hr { - margin-top: 2rem; + margin-top: 1.5rem; } .totals-box { @@ -68,6 +68,9 @@ .icon { left: 100%; + &.icon--question { + @include icon-color($color-blue); + } } input { @@ -142,9 +145,11 @@ margin-top: 0; margin-left: 0; padding-left: 0; + font-size: $base-font-size; &.icon-link__add-another-clin { - margin-top: $gap * 3; + margin-top: 0; + margin-bottom: 0; } } diff --git a/templates/task_orders/edit.html b/templates/task_orders/edit.html index e8e7fb14..3df32d82 100644 --- a/templates/task_orders/edit.html +++ b/templates/task_orders/edit.html @@ -376,7 +376,7 @@
Upload your supporting documentation
- Upload a single PDF containing all relevant information. {{ Icon('help')}} + Upload a single PDF containing all relevant information. {{ Icon('question')}}
{{ UploadInput(form.pdf, watch=True) }}
From 09582439eca9cbb9f8ef8f97ae6d4d79add3799d Mon Sep 17 00:00:00 2001 From: leigh-mil Date: Fri, 14 Jun 2019 11:23:01 -0400 Subject: [PATCH 9/9] Notes about updating icons --- templates/task_orders/edit.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/templates/task_orders/edit.html b/templates/task_orders/edit.html index 3df32d82..5ee999b1 100644 --- a/templates/task_orders/edit.html +++ b/templates/task_orders/edit.html @@ -40,6 +40,7 @@
+
+