Update tests

tests/domain/test_application_roles.py

@@ -33,3 +33,30 @@ def test_enabled_application_role():
     ApplicationRoles.enable(app_role)
 
     assert app_role.status == ApplicationRoleStatus.ACTIVE
+
+
+def test_get():
+    user = UserFactory.create()
+    application = ApplicationFactory.create()
+    app_role = ApplicationRoleFactory.create(user=user, application=application)
+
+    assert ApplicationRoles.get(user.id, application.id)
+    assert app_role.application == application
+    assert app_role.user == user
+
+
+def test_update_permission_sets():
+    user = UserFactory.create()
+    application = ApplicationFactory.create()
+    app_role = ApplicationRoleFactory.create(user=user, application=application)
+
+    view_app = [PermissionSets.get(PermissionSets.VIEW_APPLICATION)]
+    new_perms_names = [
+        PermissionSets.EDIT_APPLICATION_TEAM,
+        PermissionSets.DELETE_APPLICATION_ENVIRONMENTS,
+    ]
+    new_perms = PermissionSets.get_many(new_perms_names)
+    # view application permission is included by default
+    assert app_role.permission_sets == view_app
+    assert ApplicationRoles.update_permission_sets(app_role, new_perms_names)
+    assert set(app_role.permission_sets) == set(new_perms + view_app)

tests/forms/test_team.py

@@ -7,20 +7,25 @@ from atst.forms.team import *
 
 def test_permissions_form_permission_sets():
     form_data = {
-        "perms_env_mgmt": "",
         "perms_team_mgmt": PermissionSets.EDIT_APPLICATION_TEAM,
-        "perms_del_env": "",
+        "perms_env_mgmt": PermissionSets.VIEW_APPLICATION,
+        "perms_del_env": "View only",
     }
     form = PermissionsForm(data=form_data)
+
     assert form.validate()
-    assert form.data == [PermissionSets.EDIT_APPLICATION_TEAM]
+    assert form.data == [
+        PermissionSets.EDIT_APPLICATION_TEAM,
+        PermissionSets.VIEW_APPLICATION,
+        "View only",
+    ]
 
 
 def test_permissions_form_invalid():
     form_data = {
-        "perms_env_mgmt": "not a real choice",
         "perms_team_mgmt": PermissionSets.EDIT_APPLICATION_TEAM,
-        "perms_del_env": "",
+        "perms_env_mgmt": "not a real choice",
+        "perms_del_env": "View only",
     }
     form = PermissionsForm(data=form_data)
     assert not form.validate()

tests/routes/applications/test_team.py

@@ -10,7 +10,6 @@ def test_application_team(client, user_session):
     user_session(portfolio.owner)
 
     response = client.get(url_for("applications.team", application_id=application.id))
-
     assert response.status_code == 200