Small tweaks for adding a new application member:

- raise specific invitation type if invite not found in invitation domain classes
- more terse assignments of defaults in invitation service, smh
- terser margin expression for inline input fields
- sass formatting
- use translation for cancel link
- oxford comma for app team management permission explanation
- do not format environment roles with hyphens for role selection
- generalize some additional methods in the invitation domain base class
- use plain atst.models import path

atst/forms/application_member.py

@@ -3,7 +3,7 @@ from wtforms.fields import FormField, FieldList, HiddenField, BooleanField
 
 from .forms import BaseForm
 from .member import NewForm as BaseNewMemberForm
-from .data import FORMATTED_ENV_ROLES as ENV_ROLES
+from .data import ENV_ROLES
 from atst.forms.fields import SelectField
 from atst.domain.permission_sets import PermissionSets
 from atst.utils.localization import translate

atst/forms/data.py

@@ -218,6 +218,3 @@ REQUIRED_DISTRIBUTIONS = [
 ]
 
 ENV_ROLES = [(role.value, role.value) for role in CSPRole] + [(None, "No access")]
-FORMATTED_ENV_ROLES = [
-    (role.value, "- {} -".format(role.value)) for role in CSPRole
-] + [(None, "- No Access -")]