From 4d7ad667b7f1f7ac3137f27e6fa0b7ad2ebb6ffb Mon Sep 17 00:00:00 2001 From: George Drummond Date: Thu, 13 Jun 2019 15:49:36 -0400 Subject: [PATCH] Remove Portfolios.can_revoke_access_for --- atst/domain/portfolios/portfolios.py | 7 ------- tests/domain/test_portfolios.py | 11 ----------- 2 files changed, 18 deletions(-) diff --git a/atst/domain/portfolios/portfolios.py b/atst/domain/portfolios/portfolios.py index 69f14347..0e64cbfc 100644 --- a/atst/domain/portfolios/portfolios.py +++ b/atst/domain/portfolios/portfolios.py @@ -108,10 +108,3 @@ class Portfolios(object): portfolio.name = new_data["name"] PortfoliosQuery.add_and_commit(portfolio) - - @classmethod - def can_revoke_access_for(cls, portfolio, portfolio_role): - return ( - portfolio_role.user != portfolio.owner - and portfolio_role.status == PortfolioRoleStatus.ACTIVE - ) diff --git a/tests/domain/test_portfolios.py b/tests/domain/test_portfolios.py index 8ecbcb98..473f85de 100644 --- a/tests/domain/test_portfolios.py +++ b/tests/domain/test_portfolios.py @@ -164,17 +164,6 @@ def test_can_create_portfolios_with_matching_names(): PortfolioFactory.create(name=portfolio_name) -def test_can_revoke_access(): - portfolio = PortfolioFactory.create() - owner_role = portfolio.roles[0] - portfolio_role = PortfolioRoleFactory.create( - portfolio=portfolio, status=PortfolioRoleStatus.ACTIVE - ) - - assert Portfolios.can_revoke_access_for(portfolio, portfolio_role) - assert not Portfolios.can_revoke_access_for(portfolio, owner_role) - - def test_disabled_members_dont_show_up(session): portfolio = PortfolioFactory.create() PortfolioRoleFactory.create(portfolio=portfolio, status=PortfolioRoleStatus.ACTIVE)