remove unused domain methods and arguments

atst/routes/task_orders/index.py

@@ -1,5 +1,5 @@
 from io import BytesIO
-from flask import g, Response, current_app as app
+from flask import Response, current_app as app
 
 from . import task_orders_bp
 from atst.domain.task_orders import TaskOrders
@@ -12,7 +12,7 @@ from atst.models.permissions import Permissions
 @task_orders_bp.route("/task_orders/download_summary/<task_order_id>")
 @user_can(Permissions.VIEW_TASK_ORDER_DETAILS)
 def download_summary(task_order_id):
-    task_order = TaskOrders.get(g.current_user, task_order_id)
+    task_order = TaskOrders.get(task_order_id)
     byte_str = BytesIO()
     Docx.render(byte_str, data=task_order.to_dictionary())
     filename = "{}.docx".format(task_order.portfolio_name)
@@ -36,7 +36,7 @@ def send_file(attachment):
 @task_orders_bp.route("/task_orders/csp_estimate/<task_order_id>")
 @user_can(Permissions.VIEW_TASK_ORDER_DETAILS)
 def download_csp_estimate(task_order_id):
-    task_order = TaskOrders.get(g.current_user, task_order_id)
+    task_order = TaskOrders.get(task_order_id)
     if task_order.csp_estimate:
         return send_file(task_order.csp_estimate)
     else:
@@ -46,7 +46,7 @@ def download_csp_estimate(task_order_id):
 @task_orders_bp.route("/task_orders/pdf/<task_order_id>")
 @user_can(Permissions.VIEW_TASK_ORDER_DETAILS)
 def download_task_order_pdf(task_order_id):
-    task_order = TaskOrders.get(g.current_user, task_order_id)
+    task_order = TaskOrders.get(task_order_id)
     if task_order.pdf:
         return send_file(task_order.pdf)
     else:

atst/routes/task_orders/invite.py

@@ -11,7 +11,7 @@ from atst.models.permissions import Permissions
 @task_orders_bp.route("/task_orders/invite/<task_order_id>", methods=["POST"])
 @user_can(Permissions.EDIT_TASK_ORDER_DETAILS)
 def invite(task_order_id):
-    task_order = TaskOrders.get(g.current_user, task_order_id)
+    task_order = TaskOrders.get(task_order_id)
     if TaskOrders.all_sections_complete(task_order):
         update_officer_invitations(g.current_user, task_order)
 

atst/routes/task_orders/new.py

@@ -61,7 +61,7 @@ class ShowTaskOrderWorkflow:
     @property
     def task_order(self):
         if not self._task_order and self.task_order_id:
-            self._task_order = TaskOrders.get(self.user, self.task_order_id)
+            self._task_order = TaskOrders.get(self.task_order_id)
 
         return self._task_order
 
@@ -230,7 +230,7 @@ class UpdateTaskOrderWorkflow(ShowTaskOrderWorkflow):
                 old_name = self.task_order.portfolio_name
                 if not new_name == old_name:
                     Portfolios.update(self.task_order.portfolio, {"name": new_name})
-            TaskOrders.update(self.user, self.task_order, **self.task_order_form_data)
+            TaskOrders.update(self.task_order, **self.task_order_form_data)
         else:
             if self.portfolio_id:
                 pf = Portfolios.get(self.user, self.portfolio_id)
@@ -241,7 +241,7 @@ class UpdateTaskOrderWorkflow(ShowTaskOrderWorkflow):
                     self.form.defense_component.data,
                 )
             self._task_order = TaskOrders.create(portfolio=pf, creator=self.user)
-            TaskOrders.update(self.user, self.task_order, **self.task_order_form_data)
+            TaskOrders.update(self.task_order, **self.task_order_form_data)
 
         return self.task_order
 
@@ -251,7 +251,7 @@ def get_started():
     return render_template("task_orders/new/get_started.html")  # pragma: no cover
 
 
-def is_new_task_order(*args, **kwargs):
+def is_new_task_order(*_args, **kwargs):
     return (
         "screen" in kwargs
         and kwargs["screen"] == 1

atst/routes/task_orders/signing.py

@@ -12,7 +12,7 @@ from atst.domain.authz.decorator import user_can_access_decorator as user_can
 
 
 def find_unsigned_ko_to(task_order_id):
-    task_order = TaskOrders.get(g.current_user, task_order_id)
+    task_order = TaskOrders.get(task_order_id)
 
     if not TaskOrders.can_ko_sign(task_order):
         raise NoAccessError("task_order")
@@ -21,7 +21,7 @@ def find_unsigned_ko_to(task_order_id):
 
 
 def wrap_check_is_ko(user, _perm, task_order_id=None, **_kwargs):
-    task_order = TaskOrders.get(user, task_order_id)
+    task_order = TaskOrders.get(task_order_id)
     Authorization.check_is_ko(user, task_order)
 
     return True
@@ -58,7 +58,6 @@ def record_signature(task_order_id):
 
     if form.validate():
         TaskOrders.update(
-            user=g.current_user,
             task_order=task_order,
             signer_dod_id=g.current_user.dod_id,
             signed_at=datetime.datetime.now(),