pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Only raise FileLength validation error on files

Browse Source
This commit is contained in:
dandds
2019-06-10 19:26:44 -04:00
parent 62c794e7b8
commit 49332c5d6e
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
atst/forms/validators.py
View File

@@ -1,7 +1,10 @@
from datetime import datetime
import re import re
from werkzeug.datastructures import FileStorage
from wtforms.validators import ValidationError, StopValidation from wtforms.validators import ValidationError, StopValidation
import pendulum import pendulum
from datetime import datetime
from atst.utils.localization import translate from atst.utils.localization import translate
@@ -103,7 +106,7 @@ def RequiredIf(criteria_function, message=translate("forms.validators.is_require
def FileLength(max_length=50000000, message=None): def FileLength(max_length=50000000, message=None):
def _file_length(_form, field): def _file_length(_form, field):
if field.data is None: if field.data is None or not isinstance(field.data, FileStorage):
return True return True
content = field.data.read() content = field.data.read()

3
tests/forms/test_validators.py
View File

@@ -100,3 +100,6 @@ class TestFileLength:
with pytest.raises(ValidationError): with pytest.raises(ValidationError):
validator(dummy_form, dummy_field) validator(dummy_form, dummy_field)
dummy_field.data = "random string"
assert validator(dummy_form, dummy_field)