pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update some todos

Browse Source
This commit is contained in:
richard-dds 2019-09-25 14:59:18 -04:00
parent 30210ba09c
commit 48eb860e05
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
atst/domain/csp/cloud.py
View File

@ -452,6 +452,7 @@ class AWSCloudProvider(CloudProviderInterface):
self.access_key_id = config["AWS_ACCESS_KEY_ID"] self.access_key_id = config["AWS_ACCESS_KEY_ID"]
self.secret_key = config["AWS_SECRET_KEY"] self.secret_key = config["AWS_SECRET_KEY"]
self.region_name = config["AWS_REGION_NAME"] self.region_name = config["AWS_REGION_NAME"]
self.role_access_org_name = "OrganizationAccountAccessRole" # TODO
# TODO # TODO
self.root_account_username = None self.root_account_username = None
@ -473,8 +474,8 @@ class AWSCloudProvider(CloudProviderInterface):
# TODO: Good that we're providing RoleName, but we may want to salt it # TODO: Good that we're providing RoleName, but we may want to salt it
account_request = org_client.create_account( account_request = org_client.create_account(
Email=user.email, Email=user.email,
AccountName=account_name, # TODO AccountName=account_name, # TODO: {portfolio_name-application_name-environment_name}? or something random
RoleName=role_name, # TODO RoleName=self.org_access_role_name,
IamUserAccessToBilling="DENY", IamUserAccessToBilling="DENY",
) )