pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove now unnecessary auth check

Browse Source
This commit is contained in:
Patrick Smith 2018-08-30 14:39:07 -04:00
parent 27b85ce560
commit 457f8de608
1 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
atst/routes/requests/requests_form.py
View File

@ -44,9 +44,6 @@ def requests_form_new(screen):
) )
@requests_bp.route("/requests/new/<int:screen>/<string:request_id>", methods=["GET"]) @requests_bp.route("/requests/new/<int:screen>/<string:request_id>", methods=["GET"])
def requests_form_update(screen=1, request_id=None): def requests_form_update(screen=1, request_id=None):
if request_id:
_check_can_view_request(request_id)
request = ( request = (
Requests.get(g.current_user, request_id) if request_id is not None else None Requests.get(g.current_user, request_id) if request_id is not None else None
) )
@ -129,17 +126,3 @@ def requests_submit(request_id=None):
def view_pending_request(request_id=None): def view_pending_request(request_id=None):
request = Requests.get(g.current_user, request_id) request = Requests.get(g.current_user, request_id)
return render_template("requests/view_pending.html", data=request.body) return render_template("requests/view_pending.html", data=request.body)
# TODO: generalize this, along with other authorizations, into a policy-pattern
# for authorization in the application
def _check_can_view_request(request_id):
if (
Permissions.REVIEW_AND_APPROVE_JEDI_WORKSPACE_REQUEST
in g.current_user.atat_permissions
):
pass
elif Requests.exists(request_id, g.current_user):
pass
else:
raise UnauthorizedError(g.current_user, "view request {}".format(request_id))