From 39442c3ccd1303870670211b785bdf996249ce2c Mon Sep 17 00:00:00 2001 From: richard-dds Date: Wed, 25 Sep 2019 16:10:42 -0400 Subject: [PATCH] Fix AWSCloudProvider.create_environment --- atst/domain/csp/cloud.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/atst/domain/csp/cloud.py b/atst/domain/csp/cloud.py index 76a98ca6..38183605 100644 --- a/atst/domain/csp/cloud.py +++ b/atst/domain/csp/cloud.py @@ -7,7 +7,7 @@ from atst.models.user import User from atst.models.environment import Environment from atst.models.environment_role import EnvironmentRole -from botocore.exceptions import ClientError +from botocore.waiter import WaiterModel, create_waiter_with_client, WaiterError class GeneralCSPException(Exception): @@ -496,12 +496,14 @@ class AWSCloudProvider(CloudProviderInterface): ): org_client = self._get_client("organizations") + account_name = uuid4().hex + # Create an account. Requires organizations:CreateAccount permission # TODO: Good that we're providing RoleName, but we may want to salt it account_request = org_client.create_account( Email=user.email, AccountName=account_name, # TODO: {portfolio_name-application_name-environment_name}? or something random - RoleName=self.org_access_role_name, + RoleName=self.role_access_org_name, IamUserAccessToBilling="DENY", )