Merge pull request #343 from dod-ccpo/more-tests-for-workspaces

Add more tests for workspaces routes

tests/forms/test_financial.py

@@ -47,8 +47,8 @@ def test_funding_type_other_required_if_funding_type_is_other():
     ],
 )
 def test_treasury_code_validation(input_, expected):
-    form_data = {"treasury_code": input_}
-    form = FinancialForm(data=form_data)
+    form_data = ImmutableMultiDict([("treasury_code", input_)])
+    form = FinancialForm(form_data)
     form.validate()
     is_valid = "treasury_code" not in form.errors
 
@@ -74,8 +74,8 @@ def test_treasury_code_validation(input_, expected):
     ],
 )
 def test_ba_code_validation(input_, expected):
-    form_data = {"ba_code": input_}
-    form = FinancialForm(data=form_data)
+    form_data = ImmutableMultiDict([("ba_code", input_)])
+    form = FinancialForm(form_data)
     form.validate()
     is_valid = "ba_code" not in form.errors
 

tests/forms/test_new_request.py

@@ -1,4 +1,5 @@
 import pytest
+from werkzeug.datastructures import ImmutableMultiDict
 
 from atst.forms.new_request import DetailsOfUseForm
 
@@ -26,9 +27,13 @@ class TestDetailsOfUseForm:
         "expected_completion_date": "Less than 1 month",
     }
 
+    def _make_form(self, data):
+        form_data = ImmutableMultiDict(data.items())
+        return DetailsOfUseForm(form_data)
+
     def test_require_cloud_native_when_not_migrating(self):
         extra_data = {"jedi_migration": "no"}
-        request_form = DetailsOfUseForm(data={**self.form_data, **extra_data})
+        request_form = self._make_form({**self.form_data, **extra_data})
         assert not request_form.validate()
         assert request_form.errors == {"cloud_native": ["Not a valid choice"]}
 
@@ -38,7 +43,7 @@ class TestDetailsOfUseForm:
             "data_transfers": "",
             "expected_completion_date": "",
         }
-        request_form = DetailsOfUseForm(data={**self.form_data, **extra_data})
+        request_form = self._make_form({**self.form_data, **extra_data})
         assert not request_form.validate()
         assert request_form.errors == {
             "rationalization_software_systems": ["Not a valid choice"],
@@ -53,7 +58,7 @@ class TestDetailsOfUseForm:
         data = {**self.form_data, **self.migration_data}
         del data["organization_providing_assistance"]
 
-        request_form = DetailsOfUseForm(data=data)
+        request_form = self._make_form(data)
         assert not request_form.validate()
         assert request_form.errors == {
             "organization_providing_assistance": ["Not a valid choice"]
@@ -64,7 +69,7 @@ class TestDetailsOfUseForm:
         data["technical_support_team"] = "no"
         del data["organization_providing_assistance"]
 
-        request_form = DetailsOfUseForm(data=data)
+        request_form = self._make_form(data)
         assert request_form.validate()
 
     def test_sessions_required_for_large_projects(self):
@@ -73,26 +78,26 @@ class TestDetailsOfUseForm:
         del data["number_user_sessions"]
         del data["average_daily_traffic"]
 
-        request_form = DetailsOfUseForm(data=data)
+        request_form = self._make_form(data)
         assert not request_form.validate()
         assert request_form.errors == {
             "number_user_sessions": ["This field is required."],
             "average_daily_traffic": ["This field is required."],
         }
 
-    def test_sessions_not_required_invalid_monthly_spend(self):
+    def test_sessions_not_required_low_monthly_spend(self):
         data = {**self.form_data, **self.migration_data}
-        data["estimated_monthly_spend"] = "foo"
+        data["estimated_monthly_spend"] = "10"
         del data["number_user_sessions"]
         del data["average_daily_traffic"]
 
-        request_form = DetailsOfUseForm(data=data)
+        request_form = self._make_form(data)
         assert request_form.validate()
 
     def test_start_date_must_be_in_the_future(self):
         data = {**self.form_data, **self.migration_data}
         data["start_date"] = "01/01/2018"
 
-        request_form = DetailsOfUseForm(data=data)
+        request_form = self._make_form(data)
         assert not request_form.validate()
         assert "Must be a date in the future." in request_form.errors["start_date"]

tests/routes/test_workspaces.py

@@ -73,6 +73,59 @@ def test_update_workspace_name(client, user_session):
     assert workspace.name == "a cool new name"
 
 
+def test_view_edit_project(client, user_session):
+    owner = UserFactory.create()
+    workspace = WorkspaceFactory.create()
+    Workspaces._create_workspace_role(owner, workspace, "admin")
+    project = Projects.create(
+        owner,
+        workspace,
+        "Snazzy Project",
+        "A new project for me and my friends",
+        {"env1", "env2"},
+    )
+    user_session(owner)
+    response = client.get(
+        "/workspaces/{}/projects/{}/edit".format(workspace.id, project.id)
+    )
+    assert response.status_code == 200
+
+
+def test_create_member(client, user_session):
+    owner = UserFactory.create()
+    user = UserFactory.create()
+    workspace = WorkspaceFactory.create()
+    Workspaces._create_workspace_role(owner, workspace, "admin")
+    user_session(owner)
+    response = client.post(
+        url_for("workspaces.create_member", workspace_id=workspace.id),
+        data={
+            "dod_id": user.dod_id,
+            "first_name": "Wilbur",
+            "last_name": "Zuckerman",
+            "email": "some_pig@zuckermans.com",
+            "workspace_role": "developer",
+        },
+        follow_redirects=True,
+    )
+
+    assert response.status_code == 200
+    assert user.has_workspaces
+
+
+def test_permissions_for_view_member(client, user_session):
+    user = UserFactory.create()
+    workspace = WorkspaceFactory.create()
+    Workspaces._create_workspace_role(user, workspace, "developer")
+    member = WorkspaceUsers.add(user, workspace.id, "developer")
+    user_session(user)
+    response = client.post(
+        url_for("workspaces.view_member", workspace_id=workspace.id, member_id=user.id),
+        follow_redirects=True,
+    )
+    assert response.status_code == 404
+
+
 def test_update_member_workspace_role(client, user_session):
     owner = UserFactory.create()
     workspace = WorkspaceFactory.create()
@@ -91,6 +144,24 @@ def test_update_member_workspace_role(client, user_session):
     assert member.role == "security_auditor"
 
 
+def test_update_member_workspace_role_with_no_data(client, user_session):
+    owner = UserFactory.create()
+    workspace = WorkspaceFactory.create()
+    Workspaces._create_workspace_role(owner, workspace, "admin")
+    user = UserFactory.create()
+    member = WorkspaceUsers.add(user, workspace.id, "developer")
+    user_session(owner)
+    response = client.post(
+        url_for(
+            "workspaces.update_member", workspace_id=workspace.id, member_id=user.id
+        ),
+        data={},
+        follow_redirects=True,
+    )
+    assert response.status_code == 200
+    assert member.role == "developer"
+
+
 def test_update_member_environment_role(client, user_session):
     owner = UserFactory.create()
     workspace = WorkspaceFactory.create()
@@ -124,3 +195,32 @@ def test_update_member_environment_role(client, user_session):
     assert response.status_code == 200
     assert EnvironmentRoles.get(user.id, env1_id).role == "security_auditor"
     assert EnvironmentRoles.get(user.id, env2_id).role == "devops"
+
+
+def test_update_member_environment_role_with_no_data(client, user_session):
+    owner = UserFactory.create()
+    workspace = WorkspaceFactory.create()
+    Workspaces._create_workspace_role(owner, workspace, "admin")
+
+    user = UserFactory.create()
+    member = WorkspaceUsers.add(user, workspace.id, "developer")
+    project = Projects.create(
+        owner,
+        workspace,
+        "Snazzy Project",
+        "A new project for me and my friends",
+        {"env1"},
+    )
+    env1_id = project.environments[0].id
+    for env in project.environments:
+        Environments.add_member(env, user, "developer")
+    user_session(owner)
+    response = client.post(
+        url_for(
+            "workspaces.update_member", workspace_id=workspace.id, member_id=user.id
+        ),
+        data={"env_" + str(env1_id): None, "env_" + str(env1_id): ""},
+        follow_redirects=True,
+    )
+    assert response.status_code == 200
+    assert EnvironmentRoles.get(user.id, env1_id).role == "developer"