pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add missing required validators

Browse Source
This commit is contained in:
Patrick Smith 2018-08-20 11:39:12 -04:00
parent 9e24dd4913
commit 364d452598
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
atst/forms/request.py
View File

@ -106,6 +106,7 @@ class RequestForm(ValidatedForm):
("5PB-10PB", "5PB-10PB"), ("5PB-10PB", "5PB-10PB"),
("Above 10PB", "Above 10PB"), ("Above 10PB", "Above 10PB"),
], ],
validators=[Required()],
) )
expected_completion_date = SelectField( expected_completion_date = SelectField(
@ -117,6 +118,7 @@ class RequestForm(ValidatedForm):
("3-6 months", "3-6 months"), ("3-6 months", "3-6 months"),
("Above 12 months", "Above 12 months"), ("Above 12 months", "Above 12 months"),
], ],
validators=[Required()],
) )
cloud_native = RadioField( cloud_native = RadioField(

10
tests/forms/test_request.py
View File

@ -32,7 +32,11 @@ class TestRequestForm:
assert request_form.errors == {"cloud_native": ["Not a valid choice"]} assert request_form.errors == {"cloud_native": ["Not a valid choice"]}
def test_require_migration_questions_when_migrating(self): def test_require_migration_questions_when_migrating(self):
extra_data = {"jedi_migration": "yes"} extra_data = {
"jedi_migration": "yes",
"data_transfers": "",
"expected_completion_date": "",
}
request_form = RequestForm(data={**self.form_data, **extra_data}) request_form = RequestForm(data={**self.form_data, **extra_data})
assert not request_form.validate() assert not request_form.validate()
assert request_form.errors == { assert request_form.errors == {
@ -40,8 +44,8 @@ class TestRequestForm:
"technical_support_team": ["Not a valid choice"], "technical_support_team": ["Not a valid choice"],
"organization_providing_assistance": ["Not a valid choice"], "organization_providing_assistance": ["Not a valid choice"],
"engineering_assessment": ["Not a valid choice"], "engineering_assessment": ["Not a valid choice"],
"data_transfers": ["Not a valid choice"], "data_transfers": ["This field is required."],
"expected_completion_date": ["Not a valid choice"], "expected_completion_date": ["This field is required."],
} }
def test_require_organization_when_technical_support_team(self): def test_require_organization_when_technical_support_team(self):