Merge pull request #837 from dod-ccpo/default-env-roles-for-app-users

Use No Access as default role value for app users
This commit is contained in:
montana-mil 2019-05-22 15:07:27 -04:00 committed by GitHub
commit 2de4d1477a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 39 additions and 4 deletions

View File

@ -3,9 +3,9 @@ from wtforms.fields import FormField, FieldList, HiddenField, BooleanField
from .forms import BaseForm
from .member import NewForm as BaseNewMemberForm
from .data import ENV_ROLES
from atst.forms.fields import SelectField
from .data import ENV_ROLES, ENV_ROLE_NO_ACCESS as NO_ACCESS
from atst.domain.permission_sets import PermissionSets
from atst.forms.fields import SelectField
from atst.utils.localization import translate
@ -15,7 +15,7 @@ class EnvironmentForm(FlaskForm):
role = SelectField(
environment_name,
choices=ENV_ROLES,
default=None,
default=NO_ACCESS,
filters=[lambda x: None if x == "None" else x],
)

View File

@ -0,0 +1,36 @@
from wtforms.validators import ValidationError
from atst.forms.data import ENV_ROLES, ENV_ROLE_NO_ACCESS as NO_ACCESS
from atst.forms.application_member import *
def test_environment_form():
form_data = {
"environment_id": 123,
"environment_name": "testing",
"role": ENV_ROLES[0][0],
}
form = EnvironmentForm(data=form_data)
assert form.validate()
def test_environment_form_default_no_access():
form_data = {"environment_id": 123, "environment_name": "testing"}
form = EnvironmentForm(data=form_data)
assert form.validate()
assert form.data == {
"environment_id": 123,
"environment_name": "testing",
"role": NO_ACCESS,
}
def test_environment_form_invalid():
form_data = {
"environment_id": 123,
"environment_name": "testing",
"role": "not a real choice",
}
form = EnvironmentForm(data=form_data)
assert not form.validate()

View File

@ -1,5 +1,4 @@
from wtforms.validators import ValidationError
import pytest
from atst.domain.permission_sets import PermissionSets
from atst.forms.team import *