From 265833f3fcc55538e289b8f4bdac1a864430974b Mon Sep 17 00:00:00 2001 From: dandds Date: Thu, 11 Apr 2019 11:32:17 -0400 Subject: [PATCH] ApplicationRoles.create should accept permission set names --- atst/domain/application_roles.py | 11 +++++++++-- tests/domain/test_application_roles.py | 10 ++++++---- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/atst/domain/application_roles.py b/atst/domain/application_roles.py index 41a75c0f..0177374a 100644 --- a/atst/domain/application_roles.py +++ b/atst/domain/application_roles.py @@ -1,13 +1,20 @@ from atst.database import db from atst.models.application_role import ApplicationRole +from atst.domain.permission_sets import PermissionSets class ApplicationRoles(object): @classmethod - def create(cls, user, application, permission_sets): + def _permission_sets_for_names(cls, set_names): + return PermissionSets.get_many(set_names) + + @classmethod + def create(cls, user, application, permission_set_names): application_role = ApplicationRole(user=user, application_id=application.id) - application_role.permission_sets = permission_sets + application_role.permission_sets = ApplicationRoles._permission_sets_for_names( + permission_set_names + ) db.session.add(application_role) db.session.commit() diff --git a/tests/domain/test_application_roles.py b/tests/domain/test_application_roles.py index 02378521..ceac10e1 100644 --- a/tests/domain/test_application_roles.py +++ b/tests/domain/test_application_roles.py @@ -7,12 +7,14 @@ def test_create_application_role(): application = ApplicationFactory.create() user = UserFactory.create() - permission_sets = PermissionSets.get_many([PermissionSets.EDIT_APPLICATION_TEAM]) - application_role = ApplicationRoles.create( - application=application, user=user, permission_sets=permission_sets + application=application, + user=user, + permission_set_names=[PermissionSets.EDIT_APPLICATION_TEAM], ) - assert application_role.permission_sets == permission_sets + assert application_role.permission_sets == PermissionSets.get_many( + [PermissionSets.EDIT_APPLICATION_TEAM] + ) assert application_role.application == application assert application_role.user == user