Merge pull request #1073 from dod-ccpo/fix-migration

Apply default to environments.creator_id so column can be non-nullable
This commit is contained in:
dandds 2019-09-16 16:11:31 -04:00 committed by GitHub
commit 25a78964df
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -10,21 +10,51 @@ import sqlalchemy as sa
from sqlalchemy.dialects import postgresql from sqlalchemy.dialects import postgresql
# revision identifiers, used by Alembic. # revision identifiers, used by Alembic.
revision = 'cfab6c8243cb' # pragma: allowlist secret revision = "cfab6c8243cb" # pragma: allowlist secret
down_revision = 'f03333c42bdb' down_revision = "f03333c42bdb" # pragma: allowlist secret
branch_labels = None branch_labels = None
depends_on = None depends_on = None
def upgrade(): def upgrade():
# ### commands auto generated by Alembic - please adjust! ### # ### commands auto generated by Alembic - please adjust! ###
op.add_column('environments', sa.Column('creator_id', postgresql.UUID(as_uuid=True), nullable=False)) op.add_column(
op.create_foreign_key("fk_users_id", 'environments', 'users', ['creator_id'], ['id']) "environments",
sa.Column("creator_id", postgresql.UUID(as_uuid=True), nullable=True),
)
op.create_foreign_key(
"fk_users_id", "environments", "users", ["creator_id"], ["id"]
)
# ### end Alembic commands ### # ### end Alembic commands ###
# Default environment's creator id to the portfolio POC
conn = op.get_bind()
results = conn.execute(
"""
SELECT
DISTINCT ON (e.id) e.id as id, pr.user_id as user_id
FROM environments e
JOIN applications a ON e.application_id = a.id
JOIN portfolios p ON a.portfolio_id = p.id
JOIN portfolio_roles pr ON pr.portfolio_id = p.id
JOIN portfolio_roles_permission_sets prps ON prps.portfolio_role_id = pr.id
JOIN permission_sets ps ON prps.permission_set_id = ps.id
WHERE ps.name = 'portfolio_poc'
ORDER BY e.id;
"""
).fetchall()
for r in results:
conn.execute(
"UPDATE environments e SET creator_id = %s WHERE e.id = %s",
[r["user_id"], r["id"]],
)
op.alter_column("environments", "creator_id", nullable=False)
def downgrade(): def downgrade():
# ### commands auto generated by Alembic - please adjust! ### # ### commands auto generated by Alembic - please adjust! ###
op.drop_constraint("fk_users_id", 'environments', type_='foreignkey') op.drop_constraint("fk_users_id", "environments", type_="foreignkey")
op.drop_column('environments', 'creator_id') op.drop_column("environments", "creator_id")
# ### end Alembic commands ### # ### end Alembic commands ###