ccpo can request changes on a request

tests/domain/test_requests.py

@@ -181,10 +181,10 @@ def test_set_status_sets_revision():
     assert request.latest_revision == request.status_events[-1].revision
 
 
-def test_approve_for_financial_verification():
+def test_accept_for_financial_verification():
     request = RequestFactory.create()
     review_data = RequestReviewFactory.dictionary()
-    Requests.approve_for_financial_verification(request, review_data)
+    Requests.accept_for_financial_verification(request, review_data)
     assert request.status == RequestStatus.PENDING_FINANCIAL_VERIFICATION
     current_review = request.latest_status.review
     assert current_review.fname_mao == review_data["fname_mao"]

tests/routes/test_request_approval.py

@@ -2,6 +2,7 @@ import os
 from flask import url_for
 
 from atst.models.attachment import Attachment
+from atst.models.request_status_event import RequestStatus
 from atst.domain.roles import Roles
 
 from tests.factories import (
@@ -68,7 +69,22 @@ def test_can_submit_request_approval(client, user_session):
     user_session(user)
     request = RequestFactory.create()
     review_data = RequestReviewFactory.dictionary()
+    review_data["approved"] = True
     response = client.post(
         url_for("requests.submit_approval", request_id=request.id), data=review_data
     )
     assert response.status_code == 302
+    assert request.status == RequestStatus.PENDING_FINANCIAL_VERIFICATION
+
+
+def test_can_submit_request_denial(client, user_session):
+    user = UserFactory.from_atat_role("ccpo")
+    user_session(user)
+    request = RequestFactory.create()
+    review_data = RequestReviewFactory.dictionary()
+    review_data["denied"] = True
+    response = client.post(
+        url_for("requests.submit_approval", request_id=request.id), data=review_data
+    )
+    assert response.status_code == 302
+    assert request.status == RequestStatus.CHANGES_REQUESTED