ccpo can request changes on a request

atst/domain/requests.py

@@ -268,12 +268,22 @@ WHERE requests_with_status.status = :status
         return request
 
     @classmethod
-    def approve_for_financial_verification(cls, request, review_data):
-        Requests.set_status(request, RequestStatus.PENDING_FINANCIAL_VERIFICATION)
-
+    def _add_review(cls, request, review_data):
         request.latest_status.review = RequestReview(**review_data)
 
         db.session.add(request)
         db.session.commit()
 
         return request
+
+    @classmethod
+    def accept_for_financial_verification(cls, request, review_data):
+        Requests.set_status(request, RequestStatus.PENDING_FINANCIAL_VERIFICATION)
+
+        return Requests._add_review(request, review_data)
+
+    @classmethod
+    def request_changes(cls, request, review_data):
+        Requests.set_status(request, RequestStatus.CHANGES_REQUESTED)
+
+        return Requests._add_review(request, review_data)

atst/routes/requests/approval.py

@@ -48,7 +48,11 @@ def submit_approval(request_id):
 
     form = CCPOReviewForm(http_request.form)
     if form.validate():
-        Requests.approve_for_financial_verification(request, form.data)
+        if http_request.form.get("approved"):
+            Requests.accept_for_financial_verification(request, form.data)
+        else:
+            Requests.request_changes(request, form.data)
+
         return redirect(url_for("requests.requests_index"))
     else:
         return render_approval(request, form)