From 4a1e5e61b38f15a5c4df66e46e8d999273a31754 Mon Sep 17 00:00:00 2001
From: dandds <dan-ctr@friends.dds.mil>
Date: Wed, 17 Apr 2019 14:49:14 -0400
Subject: [PATCH] portfolio user can view application settings page

---
 atst/routes/portfolios/applications.py       | 2 +-
 templates/portfolios/applications/index.html | 2 +-
 tests/test_access.py                         | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/atst/routes/portfolios/applications.py b/atst/routes/portfolios/applications.py
index 1f91628c..6df0f25b 100644
--- a/atst/routes/portfolios/applications.py
+++ b/atst/routes/portfolios/applications.py
@@ -67,7 +67,7 @@ def get_environments_obj_for_app(application):
 
 
 @portfolios_bp.route("/portfolios/<portfolio_id>/applications/<application_id>/edit")
-@user_can(Permissions.EDIT_APPLICATION, message="view application edit form")
+@user_can(Permissions.VIEW_APPLICATION, message="view application edit form")
 def edit_application(portfolio_id, application_id):
     application = Applications.get(application_id, portfolio_id=portfolio_id)
     form = ApplicationForm(name=application.name, description=application.description)
diff --git a/templates/portfolios/applications/index.html b/templates/portfolios/applications/index.html
index 0f609310..e6743e1d 100644
--- a/templates/portfolios/applications/index.html
+++ b/templates/portfolios/applications/index.html
@@ -42,7 +42,7 @@
                 <h3 class='icon-link accordion__title' v-on:click="props.toggle">{{ application.name }}</h3>
                 <span class='accordion__description'>{{ application.description }}</span>
                 <div class='accordion__actions'>
-                  {% if user_can(permissions.EDIT_APPLICATION) %}
+                  {% if user_can(permissions.VIEW_APPLICATION) %}
                     <a class='icon-link' href='{{ url_for("portfolios.edit_application", portfolio_id=portfolio.id, application_id=application.id) }}'>
                       <span>{{ "portfolios.applications.app_settings_text" | translate }}</span>
                     </a>
diff --git a/tests/test_access.py b/tests/test_access.py
index 0208887b..075393a8 100644
--- a/tests/test_access.py
+++ b/tests/test_access.py
@@ -243,7 +243,7 @@ def test_portfolios_delete_application_access(post_url_assert_status, monkeypatc
 
 # portfolios.edit_application
 def test_portfolios_edit_application_access(get_url_assert_status):
-    ccpo = user_with(PermissionSets.EDIT_PORTFOLIO_APPLICATION_MANAGEMENT)
+    ccpo = user_with(PermissionSets.VIEW_PORTFOLIO_APPLICATION_MANAGEMENT)
     owner = user_with()
     rando = user_with()
     portfolio = PortfolioFactory.create(