pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Return a 404 if TO isn't complete

Browse Source
This commit is contained in:
George Drummond 2019-02-20 10:07:15 -05:00
parent ff1379a3ff
commit 1fad576fe4
No known key found for this signature in database
GPG Key ID: 296DD6077123BF17
2 changed files with 3 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
atst/routes/portfolios/task_orders.py
View File

@ -5,6 +5,7 @@ from flask import g, redirect, render_template, url_for, request as http_request
from . import portfolios_bp from . import portfolios_bp
from atst.database import db from atst.database import db
from atst.domain.task_orders import TaskOrders from atst.domain.task_orders import TaskOrders
from atst.domain.exceptions import NotFoundError
from atst.domain.portfolios import Portfolios from atst.domain.portfolios import Portfolios
from atst.domain.authz import Authorization from atst.domain.authz import Authorization
from atst.forms.officers import EditTaskOrderOfficersForm from atst.forms.officers import EditTaskOrderOfficersForm
@ -122,13 +123,7 @@ def task_order_invitations(portfolio_id, task_order_id):
form=form, form=form,
) )
else: else:
return redirect( raise NotFoundError("task_order")
url_for(
"portfolios.view_task_order",
task_order_id=task_order.id,
portfolio_id=portfolio.id,
)
)
@portfolios_bp.route( @portfolios_bp.route(

9
tests/routes/portfolios/test_task_orders.py
View File

@ -227,14 +227,7 @@ def test_cant_view_task_order_invitations_when_not_complete(client, user_session
task_order_id=task_order.id, task_order_id=task_order.id,
) )
) )
assert ( assert response.status_code == 404
url_for(
"portfolios.view_task_order",
task_order_id=task_order.id,
portfolio_id=portfolio.id,
)
in response.location
)
def test_ko_can_view_ko_review_page(client, user_session): def test_ko_can_view_ko_review_page(client, user_session):