diff --git a/js/components/forms/new_application.js b/js/components/forms/new_application.js index edc780e0..df7bc4e9 100644 --- a/js/components/forms/new_application.js +++ b/js/components/forms/new_application.js @@ -112,15 +112,11 @@ export default { validateAndOpenModal: function() { let isValid = this.$children.reduce((previous, newVal) => { // display textInput error if it is not valid - if (newVal.$options.name == 'savebutton') { - return true - } else { - if (!newVal.showValid) { - newVal.showError = true - } - - return newVal.showValid && previous + if (!newVal.showValid) { + newVal.showError = true } + + return newVal.showValid && previous }, true) this.validate() isValid = this.errors.length == 0 && isValid diff --git a/js/components/save_button.js b/js/components/save_button.js deleted file mode 100644 index 60eabe66..00000000 --- a/js/components/save_button.js +++ /dev/null @@ -1,18 +0,0 @@ -export default { - name: 'savebutton', - - props: { - text: String, - disabled: Boolean, - classes: String, - }, - - data: function() { - return { - displayClasses: `usa-button usa-button-primary ${this.classes}`, - } - }, - - template: - '', -} diff --git a/js/index.js b/js/index.js index e3684424..5bced706 100644 --- a/js/index.js +++ b/js/index.js @@ -33,7 +33,6 @@ import { isNotInVerticalViewport } from './lib/viewport' import DateSelector from './components/date_selector' import SidenavToggler from './components/sidenav_toggler' import KoReview from './components/forms/ko_review' -import savebutton from './components/save_button' import BaseForm from './components/forms/base_form' Vue.config.productionTip = false @@ -70,7 +69,6 @@ const app = new Vue({ EditOfficerForm, SidenavToggler, KoReview, - savebutton, BaseForm, }, diff --git a/js/mixins/form.js b/js/mixins/form.js index 0839a1b9..3fddc7f2 100644 --- a/js/mixins/form.js +++ b/js/mixins/form.js @@ -1,5 +1,3 @@ -import savebutton from '../components/save_button' - export default { mounted: function() { this.$root.$on('field-change', this.handleFieldChange) @@ -29,8 +27,4 @@ export default { default: true, }, }, - - components: { - savebutton, - }, } diff --git a/templates/components/save_button.html b/templates/components/save_button.html new file mode 100644 index 00000000..2802df1b --- /dev/null +++ b/templates/components/save_button.html @@ -0,0 +1,6 @@ +{% macro SaveButton(text, additional_classes="") -%} + {% set class = "usa-button usa-button-primary" + additional_classes %} + +{%- endmacro %} diff --git a/templates/fragments/admin/portfolio_members.html b/templates/fragments/admin/portfolio_members.html index f548f857..51c8ae33 100644 --- a/templates/fragments/admin/portfolio_members.html +++ b/templates/fragments/admin/portfolio_members.html @@ -1,5 +1,6 @@ {% from "components/icon.html" import Icon %} {% from "components/options_input.html" import OptionsInput %} +{% from 'components/save_button.html' import SaveButton %} {% from "components/modal.html" import Modal %} {% from "components/alert.html" import Alert %} diff --git a/templates/fragments/edit_user_form.html b/templates/fragments/edit_user_form.html index 436d5218..b04b1077 100644 --- a/templates/fragments/edit_user_form.html +++ b/templates/fragments/edit_user_form.html @@ -3,6 +3,7 @@ {% from "components/date_input.html" import DateInput %} {% from "components/phone_input.html" import PhoneInput %} {% from "components/date_picker.html" import DatePicker %} +{% from 'components/save_button.html' import SaveButton %}
@@ -34,11 +35,7 @@
- - + {{ SaveButton(text=("fragments.edit_user_form.save_details_button" | translate), additional_classes="usa-button-big" )}}
diff --git a/templates/portfolios/admin.html b/templates/portfolios/admin.html index 1ae6bcf5..18d2ec86 100644 --- a/templates/portfolios/admin.html +++ b/templates/portfolios/admin.html @@ -4,6 +4,7 @@ {% from "components/icon.html" import Icon %} {% from "components/text_input.html" import TextInput %} {% from "components/multi_step_modal_form.html" import MultiStepModalForm %} +{% from 'components/save_button.html' import SaveButton %} {% set secondary_breadcrumb = "navigation.portfolio_navigation.portfolio_admin" | translate %} @@ -24,7 +25,7 @@
- + {{ SaveButton(text='Save', additional_classes='usa-button-big') }}
diff --git a/templates/portfolios/applications/new.html b/templates/portfolios/applications/new.html index 9c2fc021..bc5b9a7a 100644 --- a/templates/portfolios/applications/new.html +++ b/templates/portfolios/applications/new.html @@ -4,6 +4,7 @@ {% from "components/icon.html" import Icon %} {% from "components/modal.html" import Modal %} {% from "components/text_input.html" import TextInput %} +{% from 'components/save_button.html' import SaveButton %} {% set secondary_breadcrumb = 'portfolios.applications.new_application_title' | translate %} @@ -76,10 +77,7 @@
- - + {{ SaveButton(text=('portfolios.applications.create_button_text' | translate)) }}
diff --git a/templates/portfolios/task_orders/invitations.html b/templates/portfolios/task_orders/invitations.html index 1dd1e8a6..a45a83fa 100644 --- a/templates/portfolios/task_orders/invitations.html +++ b/templates/portfolios/task_orders/invitations.html @@ -6,6 +6,7 @@ {% from "components/icon.html" import Icon %} {% from "components/text_input.html" import TextInput %} {% from "components/confirmation_button.html" import ConfirmationButton %} +{% from 'components/save_button.html' import SaveButton %} {% macro Link(text, icon_name, onClick=None, url='#', classes='') %} @@ -59,7 +60,7 @@ {{ Icon("x") }} Cancel - + {{ SaveButton(text='Save Changes') }} diff --git a/templates/portfolios/task_orders/review.html b/templates/portfolios/task_orders/review.html index a3763fa2..8e86a66a 100644 --- a/templates/portfolios/task_orders/review.html +++ b/templates/portfolios/task_orders/review.html @@ -10,7 +10,7 @@ {% from "components/alert.html" import Alert %} {% from "components/review_field.html" import ReviewField %} {% from "components/upload_input.html" import UploadInput %} - +{% from 'components/save_button.html' import SaveButton %} {% block content %} @@ -103,7 +103,7 @@ {% endblock %}
- + {{ SaveButton(text="Continue") }}
diff --git a/templates/portfolios/task_orders/so_review.html b/templates/portfolios/task_orders/so_review.html index 6b713217..d62f1aa2 100644 --- a/templates/portfolios/task_orders/so_review.html +++ b/templates/portfolios/task_orders/so_review.html @@ -2,6 +2,7 @@ {% from "components/text_input.html" import TextInput %} {% from "components/multi_checkbox_input.html" import MultiCheckboxInput %} +{% from 'components/save_button.html' import SaveButton %} {% block content %} @@ -31,7 +32,7 @@ {{ MultiCheckboxInput(form.required_distribution) }}
- + {{ SaveButton(text='Continue') }}
diff --git a/templates/task_orders/signing/signature_requested.html b/templates/task_orders/signing/signature_requested.html index 86670b30..1047de40 100644 --- a/templates/task_orders/signing/signature_requested.html +++ b/templates/task_orders/signing/signature_requested.html @@ -3,6 +3,7 @@ {% from "components/text_input.html" import TextInput %} {% from "components/checkbox_input.html" import CheckboxInput %} {% from "components/icon.html" import Icon %} +{% from 'components/save_button.html' import SaveButton %} {% block content %} @@ -38,7 +39,7 @@
- + {{ SaveButton(text=('common.sign' | translate)) }}