From 1a809418b108a06a1991c885ea129ec0abd22030 Mon Sep 17 00:00:00 2001 From: leigh-mil Date: Mon, 7 Oct 2019 10:51:18 -0400 Subject: [PATCH] Refactor out duplicate dictionary --- atst/domain/invitations.py | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/atst/domain/invitations.py b/atst/domain/invitations.py index 17f21c91..fb889aec 100644 --- a/atst/domain/invitations.py +++ b/atst/domain/invitations.py @@ -121,17 +121,8 @@ class BaseInvitations(object): previous_invitation = cls._get(token) cls._update_status(previous_invitation, InvitationStatus.REVOKED) - if user_info: - user_details = { - "email": user_info["email"], - "dod_id": user_info["dod_id"], - "first_name": user_info["first_name"], - "last_name": user_info["last_name"], - "phone_number": user_info["phone_number"], - "phone_ext": user_info["phone_ext"], - } - else: - user_details = { + if not user_info: + user_info = { "email": previous_invitation.email, "dod_id": previous_invitation.dod_id, "first_name": previous_invitation.first_name, @@ -140,7 +131,7 @@ class BaseInvitations(object): "phone_ext": previous_invitation.phone_ext, } - return cls.create(inviter, previous_invitation.role, user_details, commit=True) + return cls.create(inviter, previous_invitation.role, user_info, commit=True) class PortfolioInvitations(BaseInvitations):