From 13eb277f4a51342d7b45a1312f0c08df3dcd78cb Mon Sep 17 00:00:00 2001 From: richard-dds Date: Tue, 11 Jun 2019 14:00:31 -0400 Subject: [PATCH] Fix CTAs for funding page --- atst/models/task_order.py | 16 ++++++++++++---- styles/sections/_task_order.scss | 4 ++++ templates/portfolios/task_orders/index.html | 20 ++++++++++++++------ 3 files changed, 30 insertions(+), 10 deletions(-) diff --git a/atst/models/task_order.py b/atst/models/task_order.py index 2ea5a614..1ed722f4 100644 --- a/atst/models/task_order.py +++ b/atst/models/task_order.py @@ -64,14 +64,26 @@ class TaskOrder(Base, mixins.TimestampsMixin): else: raise TypeError("Could not set attachment with invalid type") + @property + def is_draft(self): + return self.status == Status.DRAFT + @property def is_active(self): return self.status == Status.ACTIVE + @property + def is_upcoming(self): + return self.status == Status.UPCOMING + @property def is_expired(self): return self.status == Status.EXPIRED + @property + def is_unsigned(self): + return self.status == Status.UNSIGNED + @property def is_completed(self): return all([self.pdf, self.number, len(self.clins)]) @@ -146,10 +158,6 @@ class TaskOrder(Base, mixins.TimestampsMixin): def portfolio_name(self): return self.portfolio.name - @property - def is_pending(self): - return self.status == Status.PENDING - def to_dictionary(self): return { "portfolio_name": self.portfolio_name, diff --git a/styles/sections/_task_order.scss b/styles/sections/_task_order.scss index dc97dfc1..13d7e27b 100644 --- a/styles/sections/_task_order.scss +++ b/styles/sections/_task_order.scss @@ -82,6 +82,10 @@ min-width: 10rem; } +.task-order-card__buttons .usa-button-secondary { + min-width: 14rem; +} + .task-order-summary { margin-top: $gap * 4; diff --git a/templates/portfolios/task_orders/index.html b/templates/portfolios/task_orders/index.html index 9b561678..bb33234f 100644 --- a/templates/portfolios/task_orders/index.html +++ b/templates/portfolios/task_orders/index.html @@ -7,7 +7,13 @@ {% block portfolio_content %} {% macro ViewLink(task_order, text="Edit") %} - + + {{ text }} + +{% endmacro %} + +{% macro TaskOrderAction(task_order, text="Edit", route="review_task_order", secondary=False) %} + {{ text }} {% endmacro %} @@ -30,12 +36,14 @@ {% macro TaskOrderActions(task_order) %}
- {% if task_order.is_pending %} - {{ ViewLink(task_order, text="Edit") }} - {% elif task_order.is_active %} - {{ ViewLink(task_order, text="Modify") }} + {% if task_order.is_draft %} + {{ TaskOrderAction(task_order, text="Edit") }} + {% elif task_order.is_expired %} + {{ TaskOrderAction(task_order, text="View") }} + {% elif task_order.is_unsigned %} + {{ TaskOrderAction(task_order, text="Sign", secondary=True) }} + {{ TaskOrderAction(task_order, text="View") }} {% else %} - {{ ViewLink(task_order, text="View") }} {% endif %}
{% endmacro %}