Implement log_in_user

tests/conftest.py

@@ -16,10 +16,9 @@ def app(request):
     ctx = _app.app_context()
     ctx.push()
 
-    def teardown():
-        ctx.pop()
+    yield _app
 
-    return _app
+    ctx.pop()
 
 
 def apply_migrations():
@@ -34,9 +33,6 @@ def apply_migrations():
 @pytest.fixture(scope='session')
 def db(app, request):
 
-    def teardown():
-        _db.drop_all()
-
     _db.app = app
 
     apply_migrations()

tests/domain/test_users.py

@@ -4,6 +4,7 @@ from uuid import uuid4
 from atst.domain.users import Users
 from atst.domain.exceptions import NotFoundError
 
+DOD_ID = "my_dod_id"
 
 
 def test_create_user():
@@ -17,15 +18,13 @@ def test_create_user_with_nonexistent_role():
 
 
 def test_get_or_create_nonexistent_user():
-    user_id = uuid4()
-    user = Users.get_or_create(user_id, atat_role_name="developer")
-    assert user.id == user_id
+    user = Users.get_or_create_by_dod_id(DOD_ID, atat_role_name="developer")
+    assert user.dod_id == DOD_ID
 
 
 def test_get_or_create_existing_user():
-    user_id = uuid4()
-    Users.get_or_create(user_id, atat_role_name="developer")
-    user = Users.get_or_create(user_id, atat_role_name="developer")
+    Users.get_or_create_by_dod_id(DOD_ID, atat_role_name="developer")
+    user = Users.get_or_create_by_dod_id(DOD_ID, atat_role_name="developer")
     assert user
 
 
@@ -42,8 +41,8 @@ def test_get_nonexistent_user():
 
 
 def test_get_user_by_dod_id():
-    new_user = Users.create("developer", dod_id="my_dod_id")
-    user = Users.get_by_dod_id("my_dod_id")
+    new_user = Users.create("developer", dod_id=DOD_ID)
+    user = Users.get_by_dod_id(DOD_ID)
     assert user == new_user
 
 

tests/domain/test_workspace_users.py

@@ -1,4 +1,3 @@
-import pytest
 from uuid import uuid4
 
 from atst.domain.workspace_users import WorkspaceUsers

tests/factories.py

@@ -1,7 +1,7 @@
 import factory
 from uuid import uuid4
 
-from atst.models import Request, RequestStatusEvent
+from atst.models import Request
 from atst.models.pe_number import PENumber
 from atst.models.task_order import TaskOrder
 

tests/test_auth.py

@@ -1,78 +1,30 @@
-import re
-import pytest
+from flask import session
+
 
 MOCK_USER = {"id": "438567dd-25fa-4d83-a8cc-8aa8366cb24a"}
+DOD_SDN_INFO = {
+        'first_name': 'ART',
+        'last_name': 'GARFUNKEL',
+        'dod_id': '5892460358'
+    }
+DOD_SDN = f"CN={DOD_SDN_INFO['last_name']}.{DOD_SDN_INFO['first_name']}.G.{DOD_SDN_INFO['dod_id']},OU=OTHER,OU=PKI,OU=DoD,O=U.S. Government,C=US"
+
+
 def _fetch_user_info(c, t):
     return MOCK_USER
 
-@pytest.mark.skip
-def test_redirects_when_not_logged_in():
-    pass
-    # response = yield http_client.fetch(
-    #     base_url + "/home", raise_error=False, follow_redirects=False
-    # )
-    # location = response.headers["Location"]
-    # assert response.code == 302
-    # assert response.error
-    # assert re.match("/\??", location)
 
+def test_login(client, monkeypatch):
+    monkeypatch.setattr("atst.routes.is_valid_certificate", lambda *args: True)
 
-# @pytest.mark.skip
-# def test_redirects_when_session_does_not_exist():
-    # monkeypatch.setattr("atst.handlers.main.Main.get_secure_cookie", lambda s,c: 'stale cookie!')
-    # response = yield http_client.fetch(
-    #     base_url + "/home", raise_error=False, follow_redirects=False
-    # )
-    # location = response.headers["Location"]
-    # cookie = response.headers._dict.get('Set-Cookie')
-    # # should clear session cookie
-    # assert 'atat=""' in cookie
-    # assert response.code == 302
-    # assert response.error
-    # assert re.match("/\??", location)
+    resp = client.get(
+        "/login-redirect",
+        environ_base={
+            "HTTP_X_SSL_CLIENT_VERIFY": "SUCCESS",
+            "HTTP_X_SSL_CLIENT_S_DN": DOD_SDN,
+        },
+    )
 
-
-# @pytest.mark.skip
-# def test_login_with_valid_bearer_token():
-#     monkeypatch.setattr("atst.handlers.login_redirect.LoginRedirect._fetch_user_info", _fetch_user_info)
-#     response = client.fetch(
-#         base_url + "/login-redirect?bearer-token=abc-123",
-#         follow_redirects=False,
-#         raise_error=False,
-#     )
-#     assert response.headers["Set-Cookie"].startswith("atat")
-#     assert response.headers["Location"] == "/home"
-#     assert response.code == 302
-#
-#
-# @pytest.mark.skip
-# def test_login_via_dev_endpoint():
-#     response = yield http_client.fetch(
-#         base_url + "/login-dev", raise_error=False, follow_redirects=False
-#     )
-#     assert response.headers["Set-Cookie"].startswith("atat")
-#     assert response.code == 302
-#     assert response.headers["Location"] == "/home"
-#
-#
-# @pytest.mark.skip
-# def test_login_with_invalid_bearer_token():
-#     _response = yield http_client.fetch(
-#         base_url + "/home",
-#         raise_error=False,
-#         headers={"Cookie": "bearer-token=anything"},
-#     )
-#
-# @pytest.mark.skip
-# def test_valid_login_creates_session():
-#     monkeypatch.setattr("atst.handlers.login_redirect.LoginRedirect._fetch_user_info", _fetch_user_info)
-#     assert len(app.sessions.sessions) == 0
-#     yield http_client.fetch(
-#         base_url + "/login-redirect?bearer-token=abc-123",
-#         follow_redirects=False,
-#         raise_error=False,
-#     )
-#     assert len(app.sessions.sessions) == 1
-#     session = list(app.sessions.sessions.values())[0]
-#     assert "atat_permissions" in session["user"]
-#     assert isinstance(session["user"]["atat_permissions"], list)
+    assert resp.status_code == 302
+    assert "home" in resp.headers["Location"]
+    assert session["user_id"]

tests/test_routes.py

@@ -1,6 +1,3 @@
-import pytest
-
-
 def test_routes(client):
     for path in (
         "/",