Rewrite function that builds form data for app environment roles form.

- Adds a property to ApplicationRole model so that it knows its related
  EnvironmentRole models.
- Rewrite the form data builder in the routes file so that it loops the
  application members and their environment roles to build the data
  structure.

tests/domain/test_environments.py

@@ -136,36 +136,6 @@ def test_update_env_roles_by_member():
     assert not EnvironmentRoles.get(user.id, testing.id)
 
 
-def test_get_members_by_role(db):
-    environment = EnvironmentFactory.create()
-    env_role_1 = EnvironmentRoleFactory.create(
-        environment=environment, role=CSPRole.BASIC_ACCESS.value
-    )
-    env_role_2 = EnvironmentRoleFactory.create(
-        environment=environment, role=CSPRole.TECHNICAL_READ.value
-    )
-    env_role_3 = EnvironmentRoleFactory.create(
-        environment=environment, role=CSPRole.TECHNICAL_READ.value
-    )
-    rando_env = EnvironmentFactory.create()
-    rando_env_role = EnvironmentRoleFactory.create(
-        environment=rando_env, role=CSPRole.BASIC_ACCESS.value
-    )
-
-    basic_access_members = Environments.get_members_by_role(
-        environment, CSPRole.BASIC_ACCESS.value
-    )
-    technical_read_members = Environments.get_members_by_role(
-        environment, CSPRole.TECHNICAL_READ.value
-    )
-    assert basic_access_members == [env_role_1]
-    assert rando_env_role not in basic_access_members
-    assert technical_read_members == [env_role_2, env_role_3]
-    assert (
-        Environments.get_members_by_role(environment, CSPRole.BUSINESS_READ.value) == []
-    )
-
-
 def test_get_scoped_environments(db):
     developer = UserFactory.create()
     portfolio = PortfolioFactory.create(

tests/models/test_application_role.py

@@ -1,7 +1,7 @@
 from atst.domain.permission_sets import PermissionSets
 from atst.models.audit_event import AuditEvent
 
-from tests.factories import PortfolioFactory, UserFactory
+from tests.factories import *
 
 
 def test_has_application_role_history(session):
@@ -38,3 +38,13 @@ def test_has_application_role_history(session):
     old_state, new_state = changed_event.changed_state["permission_sets"]
     assert old_state == [PermissionSets.VIEW_APPLICATION]
     assert new_state == [PermissionSets.EDIT_APPLICATION_TEAM]
+
+
+def test_environment_roles():
+    application = ApplicationFactory.create()
+    environment = EnvironmentFactory.create(application=application)
+    user = UserFactory.create()
+    application_role = ApplicationRoleFactory.create(application=application, user=user)
+    environment_role = EnvironmentRoleFactory.create(environment=environment, user=user)
+
+    assert application_role.environment_roles == [environment_role]