Implemen TaskOrder.is_completed

atst/models/task_order.py

@@ -67,7 +67,7 @@ class TaskOrder(Base, mixins.TimestampsMixin):
 
     @property
     def is_completed(self):
-        return True
+        return all([self.pdf, self.number, len(self.clins)])
 
     @property
     def is_signed(self):

tests/factories.py

@@ -272,6 +272,7 @@ class TaskOrderFactory(Base):
     portfolio = factory.SubFactory(PortfolioFactory)
     number = factory.LazyFunction(random_task_order_number)
     creator = factory.SubFactory(UserFactory)
+    _pdf = factory.SubFactory(AttachmentFactory)
 
     @classmethod
     def _create(cls, model_class, *args, **kwargs):

tests/models/test_task_order.py

@@ -17,8 +17,7 @@ from tests.factories import (
 from tests.mocks import PDF_FILENAME
 
 
-class TestPeriodOfPerformance:
-    def test_period_of_performance_is_first_to_last_clin(self):
+def test_period_of_performance_is_first_to_last_clin():
     start_date = date(2019, 6, 6)
     end_date = date(2020, 6, 6)
 
@@ -49,6 +48,13 @@ class TestPeriodOfPerformance:
     assert task_order.end_date == end_date
 
 
+def test_task_order_completed():
+    assert TaskOrderFactory.create(clins=[CLINFactory.create()]).is_completed
+    assert not TaskOrderFactory.create().is_completed
+    assert not TaskOrderFactory.create(clins=[]).is_completed
+    assert not TaskOrderFactory.create(number=None).is_completed
+
+
 class TestTaskOrderStatus:
     @patch("atst.models.TaskOrder.is_completed", new_callable=PropertyMock)
     @patch("atst.models.TaskOrder.is_signed", new_callable=PropertyMock)