remove frontend role selection for new member

tests/domain/test_portfolios.py

@@ -243,7 +243,7 @@ def test_for_user_returns_active_portfolios_for_user(portfolio, portfolio_owner)
 
 def test_for_user_does_not_return_inactive_portfolios(portfolio, portfolio_owner):
     bob = UserFactory.from_atat_role("default")
-    Portfolios.add_member(portfolio, bob, "developer")
+    Portfolios.add_member(portfolio, bob)
     PortfolioFactory.create()
     bobs_portfolios = Portfolios.for_user(bob)
 

tests/routes/portfolios/test_invitations.py

@@ -45,10 +45,9 @@ def test_new_member_accepts_valid_invite(monkeypatch, client, user_session):
     user_info = UserFactory.dictionary()
 
     user_session(portfolio.owner)
-    client.post(
+    response = client.post(
         url_for("portfolios.create_member", portfolio_id=portfolio.id),
         data={
-            "portfolio_role": "developer",
             "perms_app_mgmt": "view_portfolio_application_management",
             "perms_funding": "view_portfolio_funding",
             "perms_reporting": "view_portfolio_reports",
@@ -57,6 +56,7 @@ def test_new_member_accepts_valid_invite(monkeypatch, client, user_session):
         },
     )
 
+    assert response.status_code == 302
     user = Users.get_by_dod_id(user_info["dod_id"])
     token = user.invitations[0].token
 
@@ -101,7 +101,7 @@ def test_user_who_has_not_accepted_portfolio_invite_cannot_view(client, user_ses
     user_session(portfolio.owner)
     response = client.post(
         url_for("portfolios.create_member", portfolio_id=portfolio.id),
-        data={"portfolio_role": "developer", **user.to_dictionary()},
+        data=user.to_dictionary(),
     )
 
     # user tries to view portfolio before accepting invitation