remove portfolio_role direct relationship to role

tests/domain/test_portfolio_roles.py

@@ -11,66 +11,12 @@ from tests.factories import (
 )
 
 
-def test_can_create_new_portfolio_role():
-    portfolio = PortfolioFactory.create()
-    new_user = UserFactory.create()
-
-    portfolio_role_dicts = [{"id": new_user.id, "portfolio_role": "owner"}]
-    portfolio_roles = PortfolioRoles.add_many(portfolio.id, portfolio_role_dicts)
-
-    assert portfolio_roles[0].user_id == new_user.id
-    assert portfolio_roles[0].user.atat_role.name == new_user.atat_role.name
-    assert portfolio_roles[0].role.name == new_user.portfolio_roles[0].role.name
-
-
-def test_can_update_existing_portfolio_role():
-    portfolio = PortfolioFactory.create()
-    new_user = UserFactory.create()
-
-    PortfolioRoles.add_many(
-        portfolio.id, [{"id": new_user.id, "portfolio_role": "owner"}]
-    )
-    portfolio_roles = PortfolioRoles.add_many(
-        portfolio.id, [{"id": new_user.id, "portfolio_role": "developer"}]
-    )
-
-    assert portfolio_roles[0].user.atat_role.name == new_user.atat_role.name
-    assert portfolio_roles[0].role.name == new_user.portfolio_roles[0].role.name
-
-
-def test_portfolio_role_permissions():
-    portfolio_one = PortfolioFactory.create()
-    portfolio_two = PortfolioFactory.create()
-    new_user = UserFactory.create()
-    PortfolioRoleFactory.create(
-        portfolio=portfolio_one,
-        user=new_user,
-        role=Roles.get("developer"),
-        status=PortfolioRoleStatus.ACTIVE,
-    )
-    PortfolioRoleFactory.create(
-        portfolio=portfolio_two,
-        user=new_user,
-        role=Roles.get("developer"),
-        status=PortfolioRoleStatus.PENDING,
-    )
-
-    default_perms = set(new_user.atat_role.permissions)
-    assert len(
-        PortfolioRoles.portfolio_role_permissions(portfolio_one, new_user)
-    ) > len(default_perms)
-    assert (
-        PortfolioRoles.portfolio_role_permissions(portfolio_two, new_user)
-        == default_perms
-    )
-
-
 def test_add_portfolio_role_with_permission_sets():
     portfolio = PortfolioFactory.create()
     new_user = UserFactory.create()
     permission_sets = ["edit_portfolio_application_management"]
     port_role = PortfolioRoles.add(
-        new_user, portfolio.id, "developer", permission_sets=permission_sets
+        new_user, portfolio.id, permission_sets=permission_sets
     )
     assert len(port_role.permission_sets) == 5
     expected_names = [