From 63ca35e808ffd0785958dafcee47dadb52d5289f Mon Sep 17 00:00:00 2001 From: leigh-mil Date: Thu, 11 Oct 2018 11:50:39 -0400 Subject: [PATCH 1/2] Remove mask from PE Number input and clean up regex for match --- js/lib/input_validations.js | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/js/lib/input_validations.js b/js/lib/input_validations.js index c14b958d..c15414e1 100644 --- a/js/lib/input_validations.js +++ b/js/lib/input_validations.js @@ -54,12 +54,8 @@ export default { validationError: 'Please enter a 10-digit DoD ID number' }, peNumber: { - mask: val => { - if (val.length <= 7) return [/\d/,/\d/,/\d/,/\d/,/\d/,/\d/,/\d/,/[a-z,A-Z]/] - if (val.length === 8) return [/\d/,/\d/,/\d/,/\d/,/\d/,/\d/,/\d/,/[a-z,A-Z]/,/[a-z,A-Z]/] - return [/\d/,/\d/,/\d/,/\d/,/\d/,/\d/,/\d/,/[a-z,A-Z]/,/[a-z,A-Z]/,/[a-z,A-Z]/] - }, - match: /(0\d)(0\d)(\d)(\d{2})([a-z,A-Z]{1,3})/, + mask: false, + match: /(0\d)(0\d)(\d{3})([a-z,A-Z]{1,3})/, unmask: ['_'], validationError: 'Please enter a valid PE number. Note that it should be 7 digits followed by 1-3 letters, and should have a zero as the first and third digits.' }, From e0367dd2bdc570cd8fbffef9dbc5dbf10a494856 Mon Sep 17 00:00:00 2001 From: leigh-mil Date: Thu, 11 Oct 2018 11:51:18 -0400 Subject: [PATCH 2/2] Remove mask from BA Code input since it had the same bug --- js/lib/input_validations.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/js/lib/input_validations.js b/js/lib/input_validations.js index c15414e1..46d15ca0 100644 --- a/js/lib/input_validations.js +++ b/js/lib/input_validations.js @@ -66,11 +66,7 @@ export default { validationError: 'Please enter a valid Program Treasury Code. Note that it should be a four digit or six digit number, optionally prefixed by one or more zeros.' }, baCode: { - mask: val => { - if (val.length === 1) return [/\d/] - if (val.length === 2) return [/\d/, /\d/] - return [/\d/,/\d/,/[a-z,A-Z]/] - }, + mask: false, match: /[0-9]{2}\w?$/, unmask: [], validationError: 'Please enter a valid BA Code. Note that it should be two digits, followed by an optional letter.'